Re: [TSVN] [PATCH] Support for making patch straight onto the clipboard

Will Dean wrote:

> The appended patch adds a new button to the Create Patch 'Save As'
> dialog to allow the patch to be created on the clipboard.
>
> Comments:
>
> 1. The new dialog resource is in UK English - bizarrely, if I change it
> to US English in VS, it actually gets put in a neutral language, which
> seemed worse.

That's not a problem. I'll take a look at the resources.

> 2. I've moved all the CreatePatch code out of InitApplication into a
> function of its own. I'm not sure if there is an unspoken engagement in
> a competition to have the longest InitApplication function in MFC
> programming history, but it certainly looks a bit like it...! If
> anybody's upset by this change, then I don't mind if the code gets put
> back into InitInstance.

No problem here either.

> 3. I stole the code for writing an CStringA to the clipboard from
> elsewhere in the project. The same code appeared about three times, so
> I re-factored it into utils.cpp.

Here's a little problem: you removed the code from
TortoiseMerge/BaseView.cpp, but added the function to the Utils.cpp of
TortoiseProc. But TortoiseMerge has its own Utils.cpp file. Did it even
compile on your computer?

> I've created a new dialog with no title and one button on it, and one
> new string resource. I don't know how the translation stuff works, or
> what the impact of this is on it.

Translation won't be a problem. That's handled by our ResText tool and
the translators of course.

Ok, one big big problem with your patch:
you have to send it again, but this time not inline in the mail. As I
received it, it was inside the mail, not attached. And that means that
the mailprogram/server/whatever changed all lines. Especially all tabs
got exchanged with spaces. And also there are now linebreaks. So I
simply can't apply your patch (at least not without going through every
line in the patch manually).
Can you please send it again? If you're not sure if it'll arrive
unchanged, just zip it.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org