Stefan,
I just took an update today - you've done a great job on the /W4
warnings! Shall we go to /WX now...?
I saw a change you made in SVNStatus (only noticed it because of a conflict
with something of mine), and wondered if you might consider the appended
patch as an alternative.
This makes no functional difference to the code but is, I feel, slightly
clearer about the intention and slightly easier to maintain.
Cheers,
Will
Index: SVNStatus.cpp
===================================================================
--- SVNStatus.cpp (revision 1911)
+++ SVNStatus.cpp (working copy)
@@ -495,11 +495,7 @@
} // switch (status)
}
-#ifdef UNICODE
-int SVNStatus::LoadStringEx(HINSTANCE hInstance, UINT uID, LPTSTR
lpBuffer, int /*nBufferMax*/, WORD wLanguage)
-#else
int SVNStatus::LoadStringEx(HINSTANCE hInstance, UINT uID, LPTSTR
lpBuffer, int nBufferMax, WORD wLanguage)
-#endif
{
const STRINGRESOURCEIMAGE* pImage;
const STRINGRESOURCEIMAGE* pImageEnd;
@@ -511,6 +507,10 @@
#endif
int ret;
+#ifdef UNICODE
+ UNREFERENCED_PARAMETER(nBufferMax);
+#endif
+
HRSRC hResource = FindResourceEx(hInstance, RT_STRING,
MAKEINTRESOURCE(((uID>>4)+1)), wLanguage);
if (!hResource)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Nov 5 14:00:25 2004