Re: [TSVN] Excessive directory wandering - a more complete story

Stefan,

I'm now playing with mods to TSVN, and I'm slightly confused about what I'm
seeing.

So far, I haven't actually made any mods - I'm just tracing what gets
called when I do an F5.

In my original test structure, I have a folder open in Sub1 and then I
press F5.

I see SVNFolderStatus::BuildCache called twice:

once with /will/tsvntest/top/sub1 (the current one)
once with /will/tsvntest/top/sub1/fileS1-2.txt (the first file)

What happens on the first call, is that isFolder gets set true, so we go
into the 'isFolder' clause in BuildCache.
However, we don't pass the if (shellCache.IsRecursive() &&
!PathFileExists(exfile))

test, which means that we don't do the 'return' at line 189.

This means that we fall out into the bit which is commented:

         //it's a file, not a folder. So fill in the cache with
         //all files inside the same folder as the asked file is
         //since subversion can do this in one step

Clearly this is wrong - we *ARE* in a folder, not a file.

We then chop the 'sub1' off the end of the path, and do a get status on
that, which seems wrong, because it reads the next level up in the WC.

I'm not entirely sure what's primarily wrong here, but I don't think this
is the intended effect at all.

Cheers,

Will

-- 
Will Dean - Industrial Computing Ltd
will.dean_at_indcomp.co.uk - http://www.indcomp.co.uk/
Elmcroft, Wyke Road, Gillingham, Dorset, SP8 4NG, UK
Tel: +44 1747 831001    Fax: +44 1747 824783
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org