Re: [TSVN] possibly code issue

Martin Eckardt wrote:
> Hi Steve,
> i just reviewed the code in revision 1493 a bit. You added the
> possibility to add the log message to the commuit dialog in
> TortoiseProc.cpp.
>
> My question does this code really work? You set logmessage, but nowhere
> you set logmsg that is used in the dialog and later in the code.
>
> CString logmsg = logmessage;
> if (parser.HasKey(_T("logmsg")))
> {
> logmessage = parser.GetVal(_T("logmsg"));
> }
> if (!logmsg.IsEmpty())
> dlg.m_sLogMessage = logmsg;
>
> If I'm wrong don't worry and blame me.

You're right. This will write the logmessage to the registry instead of
the commit dialog.

Fixed in revision 1495.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Aug 4 08:13:56 2004