[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [TSVN] Password changes - possible bug?

From: David CM Weber <david.weber_at_backbonesecurity.com>
Date: 2004-06-23 18:54:00 CEST

I suspected that it was "expected" behavior. It just seems
counterintuitive to me. I would have expected this behavior:
(bastardized c++ pseudocode)

If(server_wants_credentials)
{
        if(send(saved_credentials) == INVALID_CREDENTIALS))
        {
                While(server_wants_credentials || user_hits_cancel)
                {
                        prompted_credentials = get_user_credentials();
                        if(save_credentials) {
save_creds(prompted_credentials)};
                        send(prompted_credentials) ==
INVALID_CREDENTIALS)
                }
        }
}

Instead of (correct me if I'm wrong)

If(server_wants_credentials)
{
        While(server_wants_credentials || user_hits_cancel)
        {
                if(send(saved_credentials) == INVALID_CREDENTIALS))
                {
                        prompted_credentials = get_user_credentials();
                        if(save_credentials) {
save_creds(prompted_credentials)};
                        // Note the missing "send prompted credentials"
                }
        }
}

Sorry, just reread what you wrote. I haven't looked at the code, so I
just want to understand something. Subversion itself caches the
username/password, correct? I honestly would have expected TSVN to toss
it in HKCU or someplace similar. I'm going to do an evil thing, and
cross post this over there to see if the SVN guys are aware of this
behavior, and if it's something that they should address, yadda yadda

Thanks for enlightening me. I'll try and make a more coherent first
post over there to avoid confusion.

>
> Ok, I checked the code. TSVN does nothing wrong. So its a
> subversion issue. But you have to see that since you
> previously saved the authentication
> with a different password Subversion always uses that stored
> ones, even
> if you specify a different password. So once you stored it, you must
> store it once the password changes - or you have to delete the (now
> wrong) password first.
>
> Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Jun 23 20:02:03 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.