[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-users] RE: Small issue with Subversion?

From: Mark Phippard <markp_at_softlanding.com>
Date: 2006-10-23 22:08:07 CEST

"Neidle, Jon" <Jon.Neidle@avocent.com> wrote on 10/23/2006 03:48:36 PM:

> This appears to be a minor defect in Subclipse. If you cancel or 'X' out
of
> the Lock dialog box that pops up when you first try to edit a file which
has
> the property svn:needs-lock, the lock pop-up feature does not work on
> subsequent attempts to type information into the file.
>
> I found two other workarounds to this problem in addition to the one
that
> you discovered (restarting RFT):
> 1) After you cancel out of the Lock dialog box you can invoke the Lock
> dialog box again by right-clicking on the affected file and selecting
Team >
> Lock. You can then lock the file and work on it.
> 2) After you cancel out of the Lock dialog box you can invoke the Lock
> dialog box again by closing the file, reopening it, and then trying to
type
> in it again. This will bring up the Lock dialog box.
>
> I did not see this problem listed in the Subclipse defect reporting
system
> and thus have Cc'ed the Subclipse user community on this email to see
they
> want this submitted as a new issue or if they have any questions on the
> problem. [We are using Subclipse 1.03 running on IBM Rational
Functional
> Tester. I attached an environment details file to this email.]

If there is an issue, I think it is with Eclipse. The way that this
works, is that we implement an Eclipse interface named
IFileModificationValidator which has two methods to implement
validateEdit() and validateSave(). Eclipse calls the validateEdit()
method when you attempt to modify a read only file. The method take an
IStatus object as a return value. When our implementation is called we
bring up the lock dialog. If you successfully lock the file we return
Status.OK_STATUS, if you click Cancel or the lock fails, then we return
Status.CANCEL_STATUS

What I see when I run this in debug, is that our method is only called the
first time. So once you hit Cancel, Eclipse must make the assumption you
do not want to edit the file and never calls the method again. Perhaps
this is for convenience so you do not keep getting the dialog popped up?

Anyway, I do not think there is anything that can be done in Subclipse to
change the behavior.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Mon Oct 23 22:08:25 2006

This is an archived mail posted to the Subclipse Users mailing list.