"Cain, Tom" <tcain@solekai.com> wrote on 08/21/2006 03:46:40 PM:
> As mentioned in a previous post, we intend to use the ISVNClientAdapter
API
> within a plugin we are developing. However, one thing I noticed is that
some
> errors are not thrown as exceptions, but rather posted to the
> ISVNNotifyListener. For example, the ISVNClientAdapter.lock method does
not
> throw an exception in either of the following two error cases:
> 1. Another user has the file locked
> 2. The local file is not up to date with the SVN repository
>
> Instead, the ISVNNotifyListener.logError is invoked with the error
message.
> I understand different error handling strategies exist, but I would
assume
> that there would be some indication to the caller of the lock method
that
> the lock failed (i.e. a Boolean return value, an exception, etc). Is
this
> the expected behavior? Is there any plans on improving the API to return
> error information?
It looks intentional. The commit message for r1795 is:
Updated Lock/Unlock methods. Removed some workarounds for 1.2 issues that
are resolved in 1.3.
Do not throw exceptions when options fail. Just log to console.
Your notification handler should be able to know the command being
executed, and it calls the logException method of the handler. You
couldn't deduce the error from that if you need to know the specifics?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Tue Aug 22 02:15:49 2006