[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 187] New - no true refactoring support yet (svn "renaming/moving")

From: Lars Grunewaldt <lgw_at_dark-reality.de>
Date: 2004-12-02 00:25:32 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi there,

thanks for taking such a close look, I ran into the same problem and
never dared to try it out :)

It's still very strange that Subclipse correctly reports the copy when
it's done outside the repository by "svn copy" or "svn move" (which gets
one copy and one delete), while it doesn't when it's done by Subclipse
itself.

Maybe this gives a better idea where to look for a glitch in the code?

regards,
~ Lars

Greg Irvine wrote:
| Dude, I'd take a closer look at what really happens when you commit
after a
| refactoring. I think you'll find it works fine.
|
| There is a "problem" in subclipse in that it shows things as deleted+added
| instead of "renamed/moved" but it definitely does a move/rename on the
| commit and the history is retained.
|
| The only time you might have problems is moving a class between projects
| because subclipse (apparently) does separate commits for each project when
| files from more than one project are attempted to be committed. I'm not
| sure of the side effects of doing this sort of move.
|
| But definitely, a rename/move within the same project has no issues
| whatsoever that I've seen, particularly in regards to retaining history,
| etc.
|
| Greg.
|
| I guess I should point out I'm using the javahl interface but I doubt the
| command line one doesn't work, since refactoring has been a part of
| subclipse for as long as I've been using it (>12months).
|
|
|
| -----Original Message-----
| From: mhellmund@tigris.org [mailto:mhellmund@tigris.org]
| Sent: Thursday, 2 December 2004 5:18 AM
| To: issues@subclipse.tigris.org
| Subject: [Issue 187] New - no true refactoring support yet (svn
| "renaming/moving")
|
| http://subclipse.tigris.org/issues/show_bug.cgi?id=187
| Issue #:|187
| Summary:|no true refactoring support yet (svn
| |"renaming/moving")
| Component:|subclipse
| Version:|current
| Platform:|All
| OS/Version:|All
| URL:|
| Status:|NEW
| Status whiteboard:|
| Keywords:|
| Resolution:|
| Issue type:|DEFECT
| Priority:|P2
| Subcomponent:|core
| Assigned to:|issues@subclipse
| Reported by:|mhellmund
|
|
|
|
|
|
| ------- Additional comments from mhellmund@tigris.org Wed Dec 1 10:17:40
| -0800 2004 -------
| Using the great refactoring tools within Eclipse currently causes
problems:
|
| When renaming a Java class (PreviousClass => RefactoredClass), for
instance,
| the
| refactored file is renamed in the local file system. However,
| Subclipse/Subversion doesn't "know" that it's a refactored file, so it
marks
| the
| PreviousClass file as to be deleted from the repository and adds
| "RefactoredClass" as a new file (i.e. a file without "history"). That's a
| good
| step forward compared to the first versions of subclipse already, but
| ultimately
| it would be great to provide real renaming/moving support within the
| repository
| while keeping the file's subversion history.
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: issues-unsubscribe@subclipse.tigris.org
| For additional commands, e-mail: issues-help@subclipse.tigris.org
|
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
| For additional commands, e-mail: users-help@subclipse.tigris.org
|
|

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBrlLrQWC6DTWkDAoRAiWGAJ44KBtBrFI8LWSKRDvZN6swAl+0GwCeOQ9v
It1qnwnb8wk9gin1lL2fh/0=
=9o2c
-----END PGP SIGNATURE-----
Received on Thu Dec 2 10:25:32 2004

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.