RE: [Subclipse-dev] Patch for MSCAPI support, when using SVNKIt

Hi Markus,

Thanks for the patch. It looks pretty good.

I did notice one problem in the Windows check. It's checking the constant Platform.OS_WIN32, which will never be null or empty, so it will always assume that the platform is windows. I would fix this by instead using the static isOsWindows method that already exists in AbstractClientAdapter.

Before committing, we'll also want to externalize the strings and replace the e.printStackTrace lines with our standard error handling.

But I've only seen the dialog by "tricking" it in debug, so I haven't really tested to see that it works. To really test, I'd need a server with certs. Do you have any advice for testing?

I assume the SVNKit check is because JavaHL does not support MSCAPI providers (do we know this for certain?)? It would be great if this feature could be extended to JavaHL.

Thanks again!

Steve

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=2598253

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2010-04-28 20:46:46 CEST