Hi Ennio,
I've tried your patch and it seems to work well with one small exception,
which is the case where both bugtraq:logregex an bugtraq:message properties
have been set.
From the spec:
"The property bugtraq:logregex will override bugtraq:number and
bugtraq:message.
If both bugtraq:logregex and bugtraq:message are set, then bugtraq:message
is
only used if the user enters an issue ID in the edit box of the commit
window.
Both are used in the log window to find the URL's to point to the
issuetracker."
The way I read this, bugtraq:logregex and bugtraq:message properties are not
necessarily mutually exclusive. With your patch, if bugtraq:message
property is set, the commit dialog ignores the bugtraq:logregex property
when checking for and validating an issue. So, if the committer leaves the
issue edit box (the visibility of which is determined by the presence of the
bugtraq:message property) blank, but embeds a valid issue(s) in the comment
area, the warning message is still shown.
The desired behavior, when both properties are set, would be to check for a
valid issue(s) in the comment area if the issue edit box is left blank. So
the committer has the option of entering issues in the edit box or embedded
in the comment.
If you agree with this assessment, do you want to have a go at making such a
change and submitting another patch?
Thanks,
Steve
On 7/30/09 7:34 AM, "Ennio Zarlenga" <wzzxo_at_yahoo.fr> wrote:
> Hello,
>
> The following patch fixes the minor bugs in the subclipse UI when using the
> bugtraq:logregex property:
>
> - the input field was displayed
> - warnifnoissue was broken
>
> Ref:
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=19606
> 09
>
> Ennio
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=2377040
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2009-07-30 18:35:38 CEST