[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource

From: Stephen Elsemore <selsemore_at_collab.net>
Date: Mon, 05 Jan 2009 14:03:55 -0500

For consistency, I would suggest adding the following as the first line of
the AddIgnoredPatternCommand run() command:

monitor = Policy.monitorFor(monitor)

The static monitorFor method returns a new NullProgressMonitor if the passed
monitor is null, otherwise it just returns the passed monitor.

On 1/5/09 11:43 AM, "biczok_at_freemail.hu" <biczok_at_freemail.hu> wrote:

> Hi,
>
> Seems like when anyone calls setIgnored() in LocalResource.java it will end up
> throwing a NullPointerException.
> The reason is that it calls the run() method of a newly created
> AddIgnoredPatternCommand with a null IProgressMonitor.
>
> The actual code is this:
>
> public void setIgnored() throws SVNException {
> AddIgnoredPatternCommand command = new
> AddIgnoredPatternCommand(getParent(), resource.getName());
> command.run(null);
> }
>
> Maybe nobody is calling this method currently, but shouldn't it do something
> like:
>
> command.run(new NullProgressMonitor());
>
> to avoid future surprises?
>
> Cheers,
>
> Laca
>
> ------------------------------------------------------
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=10057
> 23
>
> To unsubscribe from this discussion, e-mail:
> [dev-unsubscribe_at_subclipse.tigris.org].

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=1005885

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2009-01-05 20:04:15 CET

This is an archived mail posted to the Subclipse Dev mailing list.