[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Annotations Question

From: Mark Phippard <markphip_at_gmail.com>
Date: Mon, 1 Dec 2008 09:51:03 -0500

On Mon, Dec 1, 2008 at 12:00 AM, Joshua Frankamp <frankamp_at_gmail.com> wrote:

> I used subclipse show annotations (so recursive) to show me the
> changes to Annotations that were semi-recently made by you r3995 in
> svnClientAdapter. To recap, its changing a null line in a blame
> request to return rev 0 and author "No change". This broke some
> tightly bound tests in svnant, which I determined to be too tight so I
> loosened them up a bit. What is the story behind "No change" is that a
> magic string of some kind?
> Just an opinion, but the old values, null null and -1 seemed more
> reasonable than the new magic.

I recall there was code not expecting to get nulls and it did not seem
like showing null to a user was any value so we figured we'd just
provide a value right within the adapter.

We just randomly picked "No change" as the string we used. Basically,
suppose you ask to blame revisions 3800-3955. Any lines that were not
changed in that range are what come back with the null values. So we
used the text "No Change" here in place of null.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org
Received on 2008-12-01 15:51:24 CET

This is an archived mail posted to the Subclipse Dev mailing list.