Re: [Subclipse-dev] History as revision graph

On Thu, Jul 3, 2008 at 10:34 AM, Steve Elsemore <selsemore_at_collab.net> wrote:
> Looks good.
>
> The action is now available for folders as well as files, but it still does
> nothing when a folder is selected. There's several things you'll need to do
> to get past this.
>
> First of all, ViewGraphAction currently checks to make sure the selected
> resource is an IFile and ignores it if it is not. You'll obviously have to
> remove that check.
>
> Then, since your editor input will not necessarily be a file, you'll have to
> open your editor using something other than FileEditorInput for input. This
> means that you'll probably have to create your own editor input class (i.e.
> RevisionGraphEditorInput) that implements IEditorInput. This class will
> contain the selected IResource (just like FileEditorInput contains an
> IFile). You can probably model most of your class on the FileEditorInput
> class. And, of course, you'll need to fix your editor to work with the new
> input.
>
> Let me know if you need help with any of this.

We could potentially only make this available for files.

Why? I used to just naturally always use the TortoiseSVN option on
folders, and I always said to myself "This thing is useless. Why do
they bother to even include it." It was only when I started trying it
on files that I noticed it has some value.

I think with folders you just get too much information for it to be usable.

We can still support folder and just let the user decide if it is
usable or not, but at the same time, maybe it makes sense to just do
it for files?

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org