RE: [Subclipse-dev] Another bug in new locking code in 1.1.9

Hi Mark,
 
sorry for replying so late. I loaded your changes and now the file is
left read-only when it is locked by another user.
 
Unfortunatley, I noticed another problem while trying to lock a file
that is not locked at all. The SVN decorator turn to the black and white
checkmark but the file stays read only (I refreshed the resource
manually and checked on the file system). I know that svnkit will chnage
the read-only attribute and I tried to debug into the code that does so
but I hadproblems because it it not so easy to find the source code for
svnkit that matches the line numbers used in the svnkit jar bundled with
subclipse. Since I did not have much time the past days I did not
succeed to find the cause for this problem.
 
I hope that I have some time this evening and I will 1) check if this
also is a problem with javahl and 2) try to get svnkit debugged.
 
I thought I'd report this now since you might already know what is
causing this. If you don't I'll post more info hopefully this evening
(CET).
 
Thomas

________________________________

From: Mark Phippard [mailto:markphip@gmail.com]
Sent: Sonntag, 24. Dezember 2006 3:35
To: dev@subclipse.tigris.org
Subject: Re: [Subclipse-dev] Another bug in new locking code in 1.1.9

On 12/23/06, Mark Phippard <markphip@gmail.com> wrote:

        I am not going to attempt to tackle the error dialog issue. I
do not
        disagree with the idea, but I also think we have the Console and
that
        is what it is for. Imagine a refactor process that was locking
10-20
        files.
        
        Your analysis of the error and its importance are all correct.
I
        think you gave me enough to fix it when I get some time after
the
        holiday.

I committed a fix to trunk if you want to try it. I now only attempt to
lock files with the svn:needs-lock property set. It still uses the read
only attribute as a hint to begin the process, but files that are read
only but do not have the property set will not just be offered to make
writable. Only files with the svn:needs-lock property set get offered
to lock. This let us remove the workaround I had added to the Lock code
to make the files writable and just makes it all more accurate.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/