[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] [BUG][svnClientAdapter] Problem with SVNStatusUtils.isManaged

From: Manfred Klug <manklu_at_web.de>
Date: 2006-10-24 18:03:36 CEST

> -----Ursprüngliche Nachricht-----
> Von: Mark Phippard <markp@softlanding.com>
> Gesendet: 22.10.06 16:27:40
> An: dev@subclipse.tigris.org
> Betreff: Re: [Subclipse-dev] [BUG][svnClientAdapter] Problem with SVNStatusUtils.isManaged

> Manfred Klug <manklu@web.de> wrote on 10/22/2006 04:37:20 AM:
>
> > > And finally the patch.
> >
> > Updated patch. Due to the shortcut in LocalResource#isIgnored() it isn't
> a
> > good idea to set the status to ignored.
>
> I do not think this is doing what you want.
>
> First off, I see a general problem where a folder that is an svn:external
> is toggling back and forth between versioned and unversioned. I think it
> is probably showing the latter, where it would have previously shown the
> external decorator. This is a "simple" case where the external is
> something like this:
>
> folder url://server/repos/folder

Found and fixed. The problem that an external is displayed as outgoing addition,
should be fixed too.

> When testing with multi-level externals, all of the extra folders that get
> added show as unversioned. Is that your intent? I'd assume not, since
> that causes options like Add to Version Control to be enabled and also
> causes them to show up in things like commit.

And if you set the status to ignored, the first folder of the external with all its
unversioned resources is ignored too. Is that your intent?

> I guess it comes down to what problems are you trying to solve here?

Have you ever tried a multilevel external without the patch? Except for the
top folder, all intermediate folders are unversioned. Options like add are no
new problem. And the top folder is treated as managed with all options
like synchronize, update, branch, tag, switch etc. Presenting useless options
is a better behaviour?

The status cache has some very very big problems. This is currently
the best patch I can provide.

Manfred
_______________________________________________________________________
Viren-Scan für Ihren PC! Jetzt für jeden. Sofort, online und kostenlos.
Gleich testen! http://www.pc-sicherheit.web.de/freescan/?mc=022222

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org

Received on Tue Oct 24 18:03:45 2006

This is an archived mail posted to the Subclipse Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.