Re: [Subclipse-dev] Incomming Change Sets ready for review

Brock Janiczak <brockj@tpg.com.au> wrote on 08/31/2006 06:10:31 AM:

> Mark Phippard wrote:
> > I know that Brock also had this feature working but has held off on
> > committing. Perhaps he can pipe in with the reasons why he did not
think
> > this feature should be added.
> >
> I actually ran into a few problems. To prevent accepting changes that
> the user has not accepted, you have to update each file individually.
> This means that you are not updating any folders, so they can end up out

> of date and cause errors later. Also, it doesn't seem very 'svn like'
> to show a revision, but possibly not all of the files in it (we only
> show files in their most recent changeset). The Subversion way of doing

> things would be to either accept, reject or manually merge a whole
> revision. This would also work around the out of date folder problem as

> you have to process the lot. It would also be nice if it allowed you to

> update to a revision that is not the current head revision (something
> the CVS incoming changeset mode can't do).
> > FWIW, I'd like to see this added and I was somewhat holding a 1.2.0
> > release for this feature (and svn 1.4.0 GA).
> >
> I would like to see this too, but only if it can be implemented in such
> a way that it works well and doesn't confuse the user.

They have attached their patch to the issue. Please help me evaluate it.

Eugene, it would be useful if you evaluate the patch as well. I know you
use this feature a lot with CVS.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Thu Aug 31 19:42:55 2006