[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] toggle "show change path by default"

From: Bernd Rinn <bernd_at_sdf.lonestar.org>
Date: 2005-08-01 15:49:20 CEST

It turned out to be pretty simple to implement that on top of Eugene's
patch. I have attached the patch (to be applied to HistoryView.java).

Just one comment regarding the patch and two general question:

* I would suggest renaming the actions toggleTextWrapAction,
toggleTextAction, and toggleListAction to something more descriptive, e.g.
  toggleTextWrapAction -> toggleWrapCommentsAction,
  toggleTextAction -> toggleShowComments,
  toggleListAction -> toggleShowAffectedPathsAction.

* What's the preferred way of submitting subclipse patches: sending them
do the dev mailing list or putting them into the issue tracker?

* Is there a general rule for Eclipse (or more specifically Subclipse)
when to put some persistent setting into the preferences dialog and when
to keep them 'local' to e.g. a view?

Mark wrote:

> We will probably landing this on trunk sometime soon. The patch
> submitter, Eugene Kuleshov went on vacation last week.

> Anyway, he is combining many enhancements in his patch, but the one
> that is relevant here are view options to hide/show the affected paths
> and/orcomment. I would suggest that you combine your patch with his,
> so that when the user has hidden the affected paths part of the view,
> then it does not fetch them.
>
> If it is easier, you could just wait until his patch lands on trunk.
>
> Mark

Bernd Rinn wrote:
> This is a follow up mail to my email "Fetch affected paths on demand" to
> the users list.
>
> There I asked for a possibility to disable fetching affected paths in
> the SVN history view. The rationale behind this feature request is that
> fetching affected paths can be an expensive operation, even with "Fetch
> affected paths on demand" enabled. Especially when linking the SVN
> history view to the editor this can become an issue. Since in subclipse
> 0.9.32 it can't be disabled, I have implemented it. Please find the
> patches to core and ui attached.
>
> The patches adds two things:
> * A context menu for the tableChangePathViewer that contains one toggle
> menu item "Show affected paths". When it is switched off, affected paths
> are no longer fetched, until it is switched on again.
>
> * A preference "Show affected paths by default". This preference
> controls the default value of the menu item above.
>
> Of course it would be great if the patches could go into trunk, because
> then I wouldn't have to maintain them for new versions of subclipse. ;-)
> But even if they can't go in for some reason I would be interested in
> feedback.

-- 
Bernd Rinn

Received on Mon Aug 1 23:49:20 2005

This is an archived mail posted to the Subclipse Dev mailing list.