[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-dev] Syncinfo core rewritten

From: Martin Letenay <mle_at_whitestein.com>
Date: 2005-07-08 15:56:35 CEST

> It seems to be working pretty well now. I would like to
> commit it as is and then start working from this version for
> further refinements. Would you mind emailing me a good
> commit message for this? It is a pretty massive change so we
> ought to document it well.

Something like:
"Synchronization process and syncInfo cache reimplemented.
StatusCacheComposite replaced by SynchronizerSyncInfoCache which now stores
syncInfos directly via ISynchronizer#setSyncInfo.
StatusCacheManager#refreshStatus reimplemented so only changed statuses are
refreshed (and triggering further notifications).
Fixed sync info change listeners so they're now able to cope with phantom
resources"

>
> After I commit this, I would like to see you remove the
> deprecated bits. I think you have made it possible to switch
> back to the old way in the preferences. I do not think that
> is needed or even a very good idea.
> Let's just make everyone use this and do our best to get it
> right. It already seems to be working very good.

OK. I agree.
I just (at the very beginning) wanted to have some way back ...
I'll remove the old code after'll you'll commit the new stuff.

> Finally, for my own understanding, the serializing of the
> cache to disk is now removed. Is this because the new
> unified cache is already serialized by Eclipse? I just do
> not want to lose that feature in general as it has made a
> huge difference for me. I also got an exception when I
> closed my runtime as it was trying to serialize the cache but
> couldn't because it wasn't serializable. I am assuming that
> this is because of the mix of old and new code.

Yes, the sync info (cache) is now serialized directly by Eclipse.
(Well, I think it is, but I 'll recheck it one more time.)
The serialization exception is a remnant of the old code.

Martin
Received on Fri Jul 8 23:56:35 2005

This is an archived mail posted to the Subclipse Dev mailing list.