[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: New Subclipse Release coming

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-04-06 20:28:24 CEST

The core plugin does not currently have any dependencies on Eclipse UI
plugins so I would say that means there should not be any UI added to
core.

Mark

Panagiotis Korros <panagiotis.korros@gmail.com> wrote on 04/06/2005
02:49:17 AM:

> I gave your patch a quick look. It seems ok.
>
> The only think I noticed is that you have ui code residing in the core
plugin.
>
> The usual eclipse conventions are never to have ui in the core plugin so
as
> the core can run headless.
>
> I don't know if that is a requirement for subclipse. We may already have
ui
> code in the core plugin.

> On Apr 6, 2005 3:03 AM, Magnus Naeslund(t) <mag@fbab.net> wrote:
> Mark Phippard wrote:
> >
> > I was hoping that Panagiotis would review it. Also, he has commit
> > authority so he can just commit both of them whenever he feels like
it. As
> > long as you both test that your patch does nothing to make Eclipse
3.0.x
> > stop working, I do not have any objections.
> >
>
> Here's the polished auto-add patch up for review:
>
>
http://subclipse.tigris.org/nonav/issues/showattachment.cgi/39/subclipse-
> autoadd-rc3.diff
>
> It's on top of Panagiotis auto-share work, but a bit more simplified
> since my latest patch. Easier to follow too, hopefully.
>
> I've tested both functionalities after my changes, and they work fine.
>
> I've also tested with Eclipse 3.0.2 and everything seems to work fine as
> far as I can tell. It just doesn't have the new functionality since it
> doesn't support the 3.1 style metadata tracking.
>
> Eyeing thru the code I can't find anything in my new code that could be
> even touched by running 3.0.x except the simple dialog hooking stuff.
> But since nothing is using that except my code (that is dead in 3.0.x)
> that won't cause any problems.
>
> My evaluation is that it won't affect anyone except 3.0.x subclipse
> developers that will see "Unknown attribute 'metaFilePaths'" in
plugin.xml.
>
> So if Panagiotis is happy, he can apply it...
>
> Regards,
> Magnus

>
>
>
> --
> Take back the web http://www.getfirefox.com
>
>
_____________________________________________________________________________
> Scanned for SoftLanding Systems, Inc. by IBM Email Security Management
> Services powered by MessageLabs.
>
_____________________________________________________________________________

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Thu Apr 7 04:28:24 2005

This is an archived mail posted to the Subclipse Dev mailing list.