On 19.06.2019 11:47, Julian Foad wrote:
> We don't handle GitHub pull requests well. Should we change something?
>
> The issue:
>
> - there is a "mirror" of svn source code on GitHub [1]
> - that makes it look like people could submit pull-requests
> - a (very) few people have tried to do so [2]
> - it isn't integrated with our project work flow
> - svn committers don't even have basic permissions to manage
> PRs, such as closing a PR
> - those potential contributors get a very poor response
> (PRs left unacknowledged or abandoned in "open" state)
>
> Some potential options:
>
> * turn off the github "mirror" of svn entirely
> - replace it with a dummy project that just says where to find us
>
> * try to persuade ASF infra and GitHub to turn off the PRs UI
> - previously said to be not possible
>
> * move svn source from svn to git (ASF gitbox) hosting
> - then a github 2-way integration will be available
>
> My thoughts:
>
> The poor experience is not much of a real problem at the moment
> because the number of interactions is so tiny (10 in 7 years), but it
> gives a bad impression and I prefer to avoid ugliness like this.
> Moving to git would probably be pragmatic in objective terms, but of
> course terribly emotive so might cause more upset and ridicule than
> it's worth. Turning off PRs might be best, so might be worth asking
> again if it's possible.
Moving the source to git would be less than ideal in terms of eating our
own dogfood. It would also be a terrible move from the "marketing"
perspective.
As for handling pull requests: we do receive e-mails for those, IIRC,
although they seem to be fairly trivial. I would suggest (to Infra) to
slightly improve the integration in two ways:
* include the patch (as an attachment?) in the PR mails
* post the mail thread replies back to the PR thread on GitHub
I think such integration would be useful for more than just Subversion,
and in our case, it would make dealing with a GitHub PR more or less
transparent to our normal patch submission process.
-- Brane
Received on 2019-06-20 09:27:42 CEST