Re: Blame callback: remove start/end parameters

Not sure if that would be as helpful as the old code and/or can be done
with a compatibility wrapper. The problem is that the output arguments are
available only, long after the blame reporting is done, while with the
current implementation intermediate callbacks can be used more efficiently.

Perhaps if we document that the output arguments are set before the first
invocation of the callback, but that would be an API-first.

    Bert

On Tue, Jan 15, 2019 at 1:30 AM Johan Corveleyn <jcorvel_at_gmail.com> wrote:

> On Mon, Jan 14, 2019 at 4:13 PM Julian Foad <julianfoad_at_apache.org> wrote:
> >
> > Julian Foad wrote:
> > > The svn_client_blame_receiver4_t parameters "start_revnum" and
> > > "end_revnum" do not really belong here because they are not per-line
> > > data. They are the "resolved" versions of the input revnums to
> > > svn_client_blame6(). I introduced them in r955895, applying a patch by
> > > Johan. I propose to move them to svn_client_blame6() output parameters.
>
> Ooh, my very first patch :-). I had no clue what I was doing back
> then, and I still don't most of the time :-). Thanks for improving
> things ...
>
> --
> Johan
>
Received on 2019-01-15 10:58:53 CET