Re: svn commit: r1741096 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_fs/rep-cache.c libsvn_fs_fs/rep-cache.h libsvn_fs_fs/transaction.c libsvn_subr/sqlite.c tests/libsvn_fs/fs-test.c tests/libsvn_subr/sqlite-test.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 27 Apr 2016 13:49:39 +0300

Ivan Zhakov <ivan_at_visualsvn.com> writes:

>> + if (err && svn_error_find_cause(err, SVN_ERR_SQLITE_ROLLBACK_FAILED))
>
> There is no need check for 'err' since svn_error_find_cause() already
> checks for SVN_NO_ERROR.

Thanks, should be fixed in r1741200.

Regards,
Evgeny Kotkov
Received on 2016-04-27 12:50:06 CEST

This message: [ Message body ]
Next message: James McCoy: "Re: 1.9.4 up for signing/testing"
Previous message: Stefan Fuhrmann: "Re: 1.8.16 up for signing/testing"
In reply to: Ivan Zhakov: "Re: svn commit: r1741096 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_fs/rep-cache.c libsvn_fs_fs/rep-cache.h libsvn_fs_fs/transaction.c libsvn_subr/sqlite.c tests/libsvn_fs/fs-test.c tests/libsvn_subr/sqlite-test.c"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]