On Fri, Aug 7, 2015 at 7:53 PM, Branko Čibej <brane_at_wandisco.com> wrote:
> On 07.08.2015 15:02, Stefan Fuhrmann wrote:
> > On Fri, Aug 7, 2015 at 1:25 AM, <bert_at_qqmail.nl
> > <mailto:bert_at_qqmail.nl>> wrote:
> >
> > [And now to the proper list]
> >
> >
> >
> > On the buildbots I see
> >
> > [[[
> >
> > ..\..\..\subversion\tests\libsvn_fs_x\fs-x-pack-test.c:873,
> >
> > ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:386,
> >
> > ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:343,
> >
> > ..\..\..\subversion\libsvn_subr\io.c:3515: (apr_err=720005)
> >
> > svn_tests: E720005: Can't open file
> 'E:\svn-local\tests\subversion\tests\libsvn_fs_x': Access is denied.
> >
> > FAIL: fs-x-pack-test 13: test batch fsync
> >
> > ]]]
> >
> > after this commit
> >
> >
> >
> > It looks like the batch fsync introduced in this patch is trying
> > to open a directory as a file?
> >
> > That is not going to work on Windows, and probably on more
> > platforms. Opening a directory requires other functions.
> >
> > Note that this code is called inside a 'SVN_ON_POSIX' block, which
> > I would assume shouldn't be active on Windows.
> >
> > Yup, that's where the bug is / was. It must be "#if SVN_ON_POSIX"
> > instead of "#ifdef SVN_ON_POSIX". Fixed in r1694669.
>
> Actually, we have a bit of a tradition for using #ifdef everywhere;
> Julian made a number of changes during 1.9 development to make that
> consistent. Would be great if the SVN_ON_POSIX symbol followed that
> pattern.
>
Alright, I don't care much either way. I simply followed the
APR_HAS_XYZ style because I originally thought about
making it detected at configure time.
Changed in r1694848.
-- Stefan^2.
Received on 2015-08-11 16:31:14 CEST