Re: [PATCH] Change error reporting for xlate problems

On Sun, Jul 14, 2013 at 12:38:52PM +0200, Bert Huijben wrote:
> > From: Stefan Sperling [mailto:stsp_at_elego.de]
> > Requiring iconv for svnsync is a good idea, we need it for the
> > --source-prop-encoding option of 'svnsync sync'.
>
> Why do we need this for 'svnsync' in general?
>
> I would guess the only case where we need it would be if the user really
> asks us to translate the properties, which in general they shouldn't, as the
> properties should be encoded correctly in the original repository.

If this option is used but cannot work because the necessary support
is not compiled in, svnsync should complain.

> Note that on Windows we don't use apr-Iconv any more. There is a Windows
> specific implementation in our utf subsystem that makes the OS handle the
> conversions for us without this dependency.

Well, sure. We don't need to enforce the same set of dependencies
across windows and unix builds.
Received on 2013-07-14 12:47:14 CEST