Re: [PATCH] default to expecting new FS backends to support \n in filenames

Stefan Sperling wrote on Mon, Jul 01, 2013 at 15:40:18 +0200:
> On Mon, Jul 01, 2013 at 04:05:54PM +0300, Daniel Shahaf wrote:
> > Daniel Shahaf wrote on Mon, Jul 01, 2013 at 15:52:32 +0300:
> > > No, we should extend the test to run 'svn ls' or 'svnadmin verify' to
> > > ensure that creating the path with \n in it didn't break anything.
>
> Fair enough, that's good enough for me.
>
> But please also check that log -v returns a good list of paths.
> With the FSFS \n problem, 'svn ls' was fine but 'log -v' was
> broken (dirent data vs changed paths data).
> Verify didn't detect the 'log -v' problem (see
> http://subversion.tigris.org/issues/show_bug.cgi?id=4343).
>
> Can you also rename allow_newlines to just 'is_fsfs', please?
>
> Thanks!

Done, and nominated for backport:

http://svn.apache.org/r1498489

Thanks,

Daniel
Received on 2013-07-01 16:43:32 CEST