Re: Review of invoke-diff-cmd-feature branch

On Sun, May 19, 2013 at 08:23:13PM +0300, Daniel Shahaf wrote:
> @@ -3018,6 +3032,7 @@ svn_io_run_external_diff(const char *dir,
> if (0 == strlen(external_diff_cmd))
> return svn_error_createf(SVN_ERR_CL_INSUFFICIENT_ARGS, NULL,
> _("The --invoke-diff-cmd string was empty.\n"));
> + /* ### No newline in error messages */

Also, layering violation in the error message: this code is in
libsvn_subr and as such is not allowed to talk about "--invoke-diff-cmd";
that is a cmdline-client concept which is not valid for other potential
callers of this function.
Received on 2013-05-19 19:55:28 CEST