On Fri, May 17, 2013 at 1:40 AM, Stefan Fuhrmann
<stefan.fuhrmann_at_wandisco.com> wrote:
>
> On Thu, May 16, 2013 at 11:14 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>>
>> On Thu, May 16, 2013 at 11:48 PM, <stefan2_at_apache.org> wrote:
>> > Author: stefan2
>> > Date: Thu May 16 19:48:47 2013
>> > New Revision: 1483532
>> >
>> > URL: http://svn.apache.org/r1483532
>> > Log:
>> > We frequently use property name constants in conjunction with hash
>> > containers.
>> > Provide new wrappers around apr_hash_get and apr_hash_set that accept
>> > such
>> > string constants and statically determine their size. That minimizes
>> > the
>> > hash access costs.
>> >
>> > Mass change hash get and set calls for SVN_PROP_* constants.
>> >
>> Hi Stefan,
>>
>> Is the performance gain costs code complexity? Please understand my
>> correctly: it's great improve Subversion speed. I just don't like the
>> idea getting code more complicated to win just several cycles.
>
>
> It is not essential to use these wrappers in all places. I did that for
> symmetry.
> As for the complexity: The patch should not add any significant maintenance
> costs - no extra parameters etc.
>
It's really easy to create bugs with new API: if someone pass const
char * variable as parameter to svn_hash_sets_fixed_key(). Risk very
high IMHO, while benefits are small.
--
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-05-17 00:25:57 CEST