On Tue, Mar 26, 2013 at 12:40:56PM -0400, C. Michael Pilato wrote:
> On 03/26/2013 12:10 PM, Daniel Shahaf wrote:
> > Or we could forbid newlines in pathnames. The only problem with that is
> > that the 1.0 API promised they would work... but if no one uses that,
> > I'd be fine with calling it an erratum and disallowing it henceforth.
>
> I'm very much in the "let libsvn_fs do everything it can, and let
> libsvn_repos enforce Subversion-specific requirements" camp.
>
> Certainly, libsvn_repos should be disallowing newline-bearing paths. We
> weren't able to support these paths when our .svn/entries file was
> plaintext, we've never been able to support them in our dump format (which
> is a libsvn_repos construct), and so on.
>
> I'm not so sure about libsvn_fs. BDB should be able to handle them just
> fine, but it sounds like FSFS can't. Do we just make a post-facto
> declaration that, going forward, we won't try to support these paths in the
> FS layer?
I don't really see how supporting such paths in the FS layer makes
sense if none of the other layers can deal with them.
Are there any other tools built on top of our FS layer that rely on
being able to use newlines in filenames?
But still, I was planning on making the repos layer enforce restrictions
on filenames anyway to avoid having each filesystem deal with it separately.
Received on 2013-03-26 18:43:11 CET