On Fri, Feb 22, 2013 at 4:04 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Philip Martin <philip.martin_at_wandisco.com> writes:
>> APR 1.2.7 doesn't have such a symbol. This means the minimum APR that
>> can be used is APR 1.3.0. Until recently we have been supporting APR
>> as far back as 0.9.
>
> The function is only used for some error messages:
>
> if (apr_socket_addr_get(&sa, APR_LOCAL, skt) == APR_SUCCESS) {
> char buf[32];
> apr_sockaddr_ip_getbuf(buf, 32, sa);
> fprintf(stderr, "%s:%d", buf, sa->port);
> }
> fprintf(stderr, " r:");
> if (apr_socket_addr_get(&sa, APR_REMOTE, skt) == APR_SUCCESS) {
> char buf[32];
> apr_sockaddr_ip_getbuf(buf, 32, sa);
> fprintf(stderr, "%s:%d", buf, sa->port);
> }
>
> There may be other reasons to upgrade but I don't think we should force
> an upgrade just to support that error message.
I think it's really questionable to be running such old versions of
APR at this point. The oldest version of httpd ASF supports is 2.2.x
and 2.2.0 comes with APR 1.2.2. httpd 2.2.23 (the current version)
comes with APR 1.4.6. So i'd say at this point it's questionable to
bother supporting 0.9-1.1. 1.2 might be a little more arguable, but
I'm sure there are security issues that have never been patched in APR
1.2.x. Though some distributions may be back-porting things.
But that does seem to be a relatively minor thing to be bumping our
requirement for.
Received on 2013-02-23 02:12:50 CET