Re: svn commit: r1424708 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_ra/ libsvn_wc/

Paul Burba wrote:

> On Thu, Dec 20, 2012 at 4:56 PM, Julian Foad wrote:
>>> Author: pburba
>>> Date: Thu Dec 20 21:19:08 2012
>>> New Revision: 1424708
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1424708&view=rev
>>> Log:
>>> Store repos root relative paths in NODES.INHERITED_PROPS rather than full
>>> URLs.
>>
>> Glad to see this, overall.  One concern:
>>
>>> See http://svn.haxx.se/dev/archive-2012-12/0427.shtml
>>>
>>> * subversion/include/svn_ra.h
>>>
>>>   (svn_ra_get_inherited_props): Add a new argument allowing the API to
>>>     retrieve an array of svn_prop_inherited_item_t items with the
>>>     path_or_url member set to either a URL or (new) a repos relpath.
>>
>> Eww.  Can't we have this function do one thing and do it well?
>>
>> Let the higher layers convert to full URLs if they need to.
>
> Agreed and done in r1430638.

Thanks, Paul.  Looks good.

- Julian
Received on 2013-01-10 00:00:32 CET