Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

On Wed, Jan 9, 2013 at 8:11 PM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 09.01.2013 20:00, Stefan Fuhrmann wrote:
> > On Wed, Jan 9, 2013 at 7:42 PM, Branko Čibej <brane_at_wandisco.com
> > <mailto:brane_at_wandisco.com>> wrote:
> >
> > On 09.01.2013 19:35, Ben Reser wrote:
> > > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej
> > <brane_at_wandisco.com <mailto:brane_at_wandisco.com>> wrote:
> > >> On 09.01.2013 18:54, stefan2_at_apache.org
> > <mailto:stefan2_at_apache.org> wrote:
> > >>> - if (header->is_delta)
> > >>> + if (header->is_delta == FALSE)
> > >> Can we please use logical operators to test boolean values, not
> > >> arithmetic ones?
> >
> >
> > Hm. I somehow got the impression from other people's
> > code that they liked the more explicit version.
>
> Yah, I noticed some people prefer to code COBOL in C. :)
>
> > Personally, I prefer the shorter one.
>
> Agreed. Of course I expect this to escalate into a flamewar, but I'll
> note that while "== FALSE" is marginally acceptable, "== TRUE" is not,
> because of C's rules about truth values.
>

r1431017 has the flame bait.

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*