Re: Regarding issue #3348 ("Provide syntax which means 'include all files *not* in a changelist'")

Daniel Shahaf wrote:

> C. Michael Pilato wrote on Fri, Jan 04, 2013 at 16:25:07 -0500:
>> >> On Fri, Jan 04, 2013 at 01:23:28PM -0500, C. Michael Pilato wrote:
>> >>> Can anyone make an argument for me *not* to reintegrate my branch to trunk
>> >>> for 1.8 release?  I need to code up some more regression tests for the --cl
>> >>> "" behaviors, but I don't really want to invest that energy today if I know
>> >>> that dev@ is disinterested in seeing this new functionality in 1.8 anyway.
>>
>> Yeah, I was kinda hoping for a bit more justification myself.  Is the trunk
>> behavior what we want to ship/live with?  See, I'm having a bit of trouble
>> really remembering the driving use-case here.
>
> svn st -q --cl ""
>
> ?

I think the need for this feature is not very strong,  more like an enhancement that should be one of a set of enhancements to
 changelists than something we would plan to introduce by itself into a
1.x release if we were planning what to deliver.

On the other hand it does have some uses ("show me all the local mods that I haven't
assigned to any changelist", "assign them all to a named changelist
now"), and I consider the whole changelists feature to be a very marginal bit of functionality so it doesn't matter much either way, and it doesn't seem at all burdonsome to maintain.

I think using "--cl=''" for the UI is lame and driven by just letting the UI be dictated by the implementation.  What if we later add an option for selecting the files in *any* named changelist, for example?  We could say that "--cl=''" is a fair choice of UI for that meaning also.

Surely the UI should be something like

  --no-cl | --no-changelist

or

  --cl=none

(which would be a reserved word -- yes I know that's not fantastic either).

Then if we later add an option such as "in any named changelist" that could be

  --any-cl | --any-changelist

and then there wont be the archaic "--cl=''" hanging around as an embarrassing backward-compatibility alias for "uh... which one did it used to mean back in the 1.8 days?"

So -0.5 from me on putting this UI in 1.8 and +0 from me on putting this *feature* in 1.8.

If you all want to just put it out there as it is and not care about the UI, fair enough.

- Julian
Received on 2013-01-04 23:11:05 CET