[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_serf: truncated responses by low Timeout are not handled graceful

From: Lieven Govaerts <lgo_at_apache.org>
Date: Thu, 8 Nov 2012 21:30:57 +0100

Hi,

On Thu, Nov 8, 2012 at 1:34 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Lieven Govaerts <lgo_at_apache.org> writes:
>
>> Any truncated response should now result in an error from serf (since
>> serf trunk r1678). It's not clear to me if this error
>> SERF_ERROR_TRUNCATED_HTTP_RESPONSE was returned from serf but then
>> ignored in svn, or not returned at all.
>
> I was using 1.1.x with the patches you and Ivan posted so it would not
> have been returning that error.

The patch I sent you earlier used another error code, but the result
should be the same. You saw that in your logs as error "The server
sent an improper HTTP response".

That patch only checked bodies for responses with Content-Length
header. The REPORT response is chunked encoded, hence no error was
reported by serf when the server aborted the REPORT response
connection.
I've added a similar check for chunked-encoded response bodies in serf r1685.

My expectation is that with serf trunk up to date r1685 you'll now
only see the error "The server sent a truncated HTTP response body."
instead of asserts, checksum or other svn errors.

Lieven
Received on 2012-11-08 21:31:52 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.