Re: [PATCH] Add platform information to user agent string

On Tue, Oct 30, 2012 at 7:49 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Tue, Oct 30, 2012 at 07:28:27PM +0400, Ivan Zhakov wrote:
>> Hi,
>>
>> I think it will be useful to add client platform information to user
>> agent string, to use it Apache HTTP Server configuration or Subversion
>> hooks. Within my patch applied user agent will be like this:
>> SVN/1.8.0 (Windows) serf/1.1.1 TortoiseSVN/1.8.0
>> SVN/1.8.0 (Macintosh) serf/1.1.1
>> SVN/1.8.0 (FreeBSD) serf/1.1.1
>>
>> [[[
>> * subversion/libsvn_ra_serf/ra_serf.h
>> (USER_AGENT_PLATFORM): New.
>> (USER_AGENT): Add platform information.
>> ]]]
>>
>> Any objections?
>
> Some users might not want to broadcast this information.
> Should we provide a way for users to override this?
> Maybe from the client configuration file?
>
You already broadcast this information when browsing the Internet :)

Also we already broadcast SVN version information. So I don't see big
issue here.

-- 
Ivan Zhakov