Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py tests/cmdline/svntest/actions.py

On 08/21/2012 03:37 PM, Mark Phippard wrote:
> On Tue, Aug 21, 2012 at 3:29 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>
>> If the community decides to simply modify start-commit to run *after* the
>> txn gets created and populated with txnprops, that's fine with me. I
>> assumed that that change was undesirable due to the fact mentioned
>> elsethread about how start-commit would no longer be useful for keeping a
>> would-be read-only repository read-only.
>
> start-commit does not currently receive the txn-id, so I do not see
> how we can use/move it for svn:log access anyway. How about a single
> new hook called something like start-commit-txn or something like
> that?

We've added parameters to the end of a hook before (ACTION was added to
post-revprop-change in Subversion 1.2.0), so I figured we'd just tack txn-id
onto the end of the current start-txn argument list. Existing scripts won't
care about the extra arg; new or updated scripts can use it to do the
svn:log checks.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development