On Tue, Jun 19, 2012 at 12:37:06PM +0200, Vincent Lefevre wrote:
> Well, not all copy events should be affected. For instance, if a file
> is moved from a directory to another one, this should be shown in the
> log. Here what is copied is not the file itself, but the directory
> above it.
True. And the file is (semantically) copied along with it. Whether or not
this is a change of the file itself is a matter of interpretation. It is
certainly a change that's related to the file's history. But I don't know
which side of this argument I prefer, to be honest.
> > I would argue this is, if at all, a cosmetic problem in 'svn log' output
> > that can be worked around with a filtering wrapper.
> I'm not complaining much on the output except that it is not consistent
> with the last changed rev when the copy was done. The question is: Is
> this regarded as a bug? If it is not, this should be documented.
Documented where, and for whom? I don't strictly object to documenting
this but I don't want to spend time on it myself.
FWIW, there is related documentation in the docstring of the
svn_fs_history_prev() function, which is used during 'svn log' to find
the next relevant node-id (a node-id is the ID of an instance of an object,
as it existed at some path in some particular revision):
* @note This function uses node-id ancestry alone to determine
* modifiedness, and therefore does NOT claim that in any of the
* returned revisions file contents changed, properties changed,
* directory entries lists changed, etc.
This is the most efficient way to scan node history in the filesystem.
It has the side-effect of showing all copies that affected the object
either directly or indirectly.
I don't think we really need to document minute behaviour details such
as this in the help output or the book. Our user support forums serve the
purpose of addressing specific questions such as yours quite well. But if
you have a concrete suggestions as to where in the book, for example, this
detail should be explained, and how, please share it (preferrably in the
form of a diff against the help text or the book's text).
Received on 2012-06-19 13:36:46 CEST