[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Type narrowing warnings on Mac OS x64 as of r1349288

From: Branko Čibej <brane_at_apache.org>
Date: Thu, 14 Jun 2012 13:37:39 +0200

On 14.06.2012 12:45, Stefan Fuhrmann wrote:
> On 06/12/2012 02:35 PM, Philip Martin wrote:
>> Branko Čibej<brane_at_apache.org> writes:
>>
>>> Better than spamming #svn-dev, here's the current list of 64-32bit
>>> narrowing warnings I get on my 64-bit mac wit Xcode 4.3.3's gcc. Taking
>>> a quick look at these, every case appears to be a valid warning that
>>> needs to be looked at and verified that the narrowing doesn't affect
>>> the
>>> value.
>>>
>>> i don't know why these warnings don't show up on Linux and/or with
>>> newer
>>> versions of GCC.
>> They show up if one uses -Wconversion (on my 64 bit Linux platform) but
>> they are swaped by other warnings so it is not enabled by default. For
>> example this file:
>>
>>> subversion/libsvn_subr/cache-membuffer.c: In function
>>> 'svn_cache__membuffer_cache_create':
>>> subversion/libsvn_subr/cache-membuffer.c:1078: warning: implicit
>>> conversion shortens 64-bit value into a 32-bit value
>> has these warnings with -Wconversion -Wno-sign-conversion on 64 bit
>
> Good to know these switches.

And in the Mac OS build we use -Wshorten-64-to-32, which appears to be
an apple-gcc-specific switch that doesn't produce as much crud in the
output.

-- Brane
Received on 2012-06-14 13:37:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.