On 06/10/2012 09:28 AM, Justin Erenkrantz wrote:
> On Friday, June 8, 2012, C. Michael Pilato wrote:
>
> On 06/08/2012 03:15 PM, Ivan Zhakov wrote:
> > Wow, but performance will be much more interesting if we inline
> > properties to REPORT response. Mike, could you please share your
> > incomplete patch for including properties to REPORT response?
>
> Sure. Attached.
>
>
> From a quick review of the patch, I am not seeing how we are delaying the
> client's editor drive to set the property until we have received the file
> contents. As I read it, we would set the properties on each file as we walk
> the REPORT response.
>
> As I understand it, we have repeatedly stated here on list that we are not
> supposed to tell the editor (esp. Ev2) about any of the properties until we
> have the file contents too because then the editor would have too many
> handles open and kill us with resource exhaustion. -- justin
My patch doesn't change the ordering, delaying, etc. of anything. If
there's a problem there, that problem preexists. All my patch does is send
properties for added files/dirs, too (since the server has long been sending
the same for "opened" files/dirs (in the editor sense of the word "open").
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Received on 2012-06-11 12:40:58 CEST