> -----Original Message-----
> From: Johan Corveleyn [mailto:jcorvel_at_gmail.com]
> Sent: dinsdag 5 juni 2012 13:08
> To: Bert Huijben
> Cc: dev_at_subversion.apache.org
> Subject: Re: Failing test basic_tests.py 29 (check that repos root gets set on
> checkout)
>
> On Tue, Jun 5, 2012 at 1:02 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
> >> -----Original Message-----
> >> From: Johan Corveleyn [mailto:jcorvel_at_gmail.com]
> >> Sent: dinsdag 5 juni 2012 02:00
> >> To: Branko Čibej
> >> Cc: dev_at_subversion.apache.org
> >> Subject: Re: Failing test basic_tests.py 29 (check that repos root gets set
> on
> >> checkout)
> >>
> >> On Mon, Apr 23, 2012 at 6:11 AM, Branko Čibej <brane_at_apache.org>
> wrote:
> >> > On 23.04.2012 00:00, Johan Corveleyn wrote:
> >> >> On Wed, Apr 18, 2012 at 7:49 AM, Daniel Shahaf <danielsh_at_elego.de>
> >> wrote:
> >> >>> Hyrum K Wright wrote on Tue, Apr 17, 2012 at 16:27:00 -0500:
> >> >>>> On Tue, Apr 17, 2012 at 4:05 PM, Johan Corveleyn
> <jcorvel_at_gmail.com>
> >> wrote:
> >> >>>>> On Tue, Apr 17, 2012 at 10:55 PM, Hyrum K Wright
> >> >>>>> <hyrum.wright_at_wandisco.com> wrote:
> >> >>>>>> On Tue, Apr 17, 2012 at 3:48 PM, Johan Corveleyn
> >> <jcorvel_at_gmail.com> wrote:
> >> >>>>>>> On Tue, Apr 17, 2012 at 10:42 AM, Philip Martin
> >> >>>>>>> <philip.martin_at_wandisco.com> wrote:
> >> >>>>>>>> Johan Corveleyn <jcorvel_at_gmail.com> writes:
> >> >>>>>>>>
> >> >>>>>>>>> Apparently, the test is comparing the 'Repository Root' from
> the
> >> >>>>>>>>> output of 'svn info' with the expected repository url. When I
> run
> >> 'svn
> >> >>>>>>>>> info' manually on ...\svn-test-
> work\working_copies\basic_tests-
> >> 29, I
> >> >>>>>>>>> see the following:
> >> >>>>>>>>>
> >> >>>>>>>>> [[[
> >> >>>>>>>>> Path: R:\test\subversion\tests\cmdline\svn-test-
> >> work\working_copies\basic_tests-29
> >> >>>>>>>>> Working Copy Root Path:
> >> >>>>>>>>> R:\test\subversion\tests\cmdline\svn-test-
> >> work\working_copies\basic_tests-29
> >> >>>>>>>>> URL: file:///R%7C/test/subversion/tests/cmdline/svn-test-
> >> work/local_tmp/repos
> >> >>>>>>>>> Repository Root:
> >> >>>>>>>>> file:///R%7C/test/subversion/tests/cmdline/svn-test-
> >> work/local_tmp/repos
> >> >>>>>>>>> ]]]
> >> >>>>>>>>>
> >> >>>>>>>>> So the '%7C' instead of ':' seems to be the problem (BTW,
> %7C is
> >> the
> >
> > With the 1.7+ canonicalization rules both
> > file:///C:/path
> > and
> > file:///C|/path
> > are valid urls, but only the first form is the canonical format.
> (svn_uri_canonicalize() will handle this, just like it updates http://host:80/dir
> to http://host/dir, etc.)
> >
> > Until early in Subversion 1.7 development the test suite produced the
> second form, while it was then updated to produce the first form.
I just ran some tests in an attempt to confirm this behavior and the %7C form is *also* canonical in 1.7 and trunk. The '|' form is not.
Bert
>
> Interesting. Do you know which revision, or around when this change
> was made? Or do you know in which file I should look ('blame') for
> this change?
>
> If I understand you correctly, before 1.7 (1.6 and earlier) the
> testsuite also used the second form?
>
> --
> Johan
Received on 2012-06-05 13:23:25 CEST