[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Mon, 04 Jun 2012 11:54:31 +0200

Daniel Shahaf wrote:
> stefan2_at_apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -0000:
>> Author: stefan2
>> Date: Sun Apr 29 09:12:48 2012
>> New Revision: 1331883
>>
>> URL: http://svn.apache.org/viewvc?rev=1331883&view=rev
>> Log:
>> SvnAdmin should always have revprop caching enabled such that
>> the infrastructure is being set up to notify *other* processes of
>> changes done by e.g. setrevprop.
>>
>> Even if the revprop update infrastructure fails for some reason,
>> the impact on svnadmin is low because it imposes a small overhead
>> for some operations but the process will always see its own changes.
>> Foreign changes may or may not become visible to the tool while
>> it is running -- just as today.
>>
> Perhaps the config API should allow people to enable "I will notify
> other processes of my changes" without enabling "I will cache revprops
> in memory"?

I've had a full implementation of that but then I realized
that it is not useful to disable the caching part as we often
do repeated lookups to different properties of the same
revision (i.e. access the same data container). Moreover,
the patch for the "notify only" functionality was much
larger than I had expected because instead of "on" / "off",
there was at least one additional state to manage.

Still, thanks for the suggestion.

-- Stefan^2.
Received on 2012-06-04 11:55:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.