[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1344347 - /subversion/trunk/subversion/libsvn_subr/config_file.c

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: Fri, 1 Jun 2012 11:06:18 -0700

On Fri, Jun 1, 2012 at 9:58 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> SVNParentPath and AuthzSVNReposRelativeAccessFile make doing it at
> config-time a bit complicated.  Would the server scan the SVNParentPath
> directory to locate all the repositories?  A repository created later
> would require a reload?

For those two directives, it'd just need to walk the children
directories...so, that's feasible to do at config-time. And, yes,
without a validity check at connection/request-time, we'd need to do a
graceful whenever the repositories or authz files change.

Worst case scenario is that we could load it up at config-time, if it
is invalid, we just fallback to doing it on a per-connection basis.
I'm not entirely sure whether we'd be able to atomically update the
shared config structure if we wanted to stash it in the config object
- though, I guess we could do that too, but it'd add a bit of
complexity that may or may not be worth it.

I don't know how much of a real-world penalty this parsing actually
has (Bert seems to think it is quite significant), but if we wanted to
minimize the I/O, that's the path I think we should take. -- justin
Received on 2012-06-01 20:06:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.