[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1344825 - in /subversion/trunk/tools/dev/mergegraph: mergegraph.py save_as_sh.py

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 31 May 2012 20:24:39 -0400

On May 31, 2012 4:45 PM, "Julian Foad" <julianfoad_at_btopenworld.com> wrote:
>
> I (Julian Foad) wrote:
>
> > Greg Stein wrote:
> >>> +def command(out, cmd, *args):
> >>> + """Write the shell command CMD with the arguments ARGS to the
file-like
> >>> + object OUT."""
> >> Please review my earlier comments about standard docstring formatting
in
> >> Python. More specifically, PEP 8. (Google it)
> >
> > OK, r1344888 for 'most
> > importantly, the """ that ends a multiline docstring should be
> > on a line by itself [...]'. Anything further will have to wait till
another
> > day.
>
> Let me add a few more words here. I support efforts to both standardize
and raise the usefulness of doc strings. I just haven't yet spent the time
to read PEP 257 (being the relevant one) in full, digest it into my
Python-commenting brain-space, decide what subset of its suggestions are
appropriate for us to use in scripts like these, and go back and change
them.

Not a problem. As long as we move towards the PEP styles in time. I
consider using the standardized docstrings as being similar to the doxygen
rules (and what we've established for internal docstrings).

Thx,
-g
Received on 2012-06-01 09:31:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.