Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check C++ pointer extracted from the java object
From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 31 May 2012 03:35:42 -0400
On Thu, May 31, 2012 at 12:43 AM, Vladimir Berezniker
Replying to just this patch. The second patch seems pretty mechanical.
(sorry, but the patch doesn't inline into this response, so let's just
The macro argument substitutions need to be parenthesized for safety.
Next bit: the indentation in the diff seems to be off. Are there TAB
Lastly, there is an extra space character before the ";" in the return
Fix the above three problems, and I'm +1 for you to commit just patch #1.
I have not reviewed #2, but the first patch seems reasonable to
I do seem to recall that C++ tried to do away with the preprocessor.
This is an archived mail posted to the Subversion Dev mailing list.