[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Using svn_hash__make instead of apr_hash__make

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 19 May 2012 21:33:49 -0400

I thought the whole reason for variant results was to avoid O(N^2) attacks
against the hash table. You would be defeating that work.

I see no reason to use a stable hash. If outputs are supposed to stable,
then the *presentation * layer should be stabilizing. Not our core data
structure.

This is the same kind of silliness that stsp made to our core data
structures. I still think that should be reverted in favor of presentation
changes.

Cheers,
-g
On May 19, 2012 8:46 PM, "Stefan Fuhrmann" <stefanfuhrmann_at_alice-dsl.de>
wrote:

> Hi all,
>
> svn_hash__make is basically apr_hash__make with
> a hash function that will produce the same results
> (element order etc) with APR 1.4.6 as well as earlier
> APR versions. Without it, different test runs will result
> in different results. As a bonus, we save some runtime.
>
> I have a patch sitting on my machine that will do a
> global replace of all 500+ locations where we create
> APR hashes. Often, we need to add another #include.
> There is no further change but the patch is large.
>
> If there are no strong objections, I will commit the
> change next weekend.
>
> -- Stefan^2.
>
Received on 2012-05-20 03:34:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.