[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1340592 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 19 May 2012 20:06:00 -0400

How about a comment in the code? The log message is not the proper location
to document why a query is constructed in a certain way.
On May 19, 2012 7:46 PM, <rhuijben_at_apache.org> wrote:

> Author: rhuijben
> Date: Sat May 19 23:45:56 2012
> New Revision: 1340592
>
> URL: http://svn.apache.org/viewvc?rev=1340592&view=rev
> Log:
> * subversion/libsvn_wc/wc-queries.sql
> (STMT_HAS_SERVER_EXCLUDED_NODES): Only select descendants of the node as
> we
> only call it on existing nodes. This makes sqlite handle the right index
> and shaves about 60% of the time to delete individual 400 files from my
> working copy.
>
> Modified:
> subversion/trunk/subversion/libsvn_wc/wc-queries.sql
>
> Modified: subversion/trunk/subversion/libsvn_wc/wc-queries.sql
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc-queries.sql?rev=1340592&r1=1340591&r2=1340592&view=diff
>
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_wc/wc-queries.sql (original)
> +++ subversion/trunk/subversion/libsvn_wc/wc-queries.sql Sat May 19
> 23:45:56 2012
> @@ -884,9 +884,8 @@ LIMIT 1
> -- STMT_HAS_SERVER_EXCLUDED_NODES
> SELECT local_relpath FROM nodes
> WHERE wc_id = ?1
> - AND (?2 = ''
> - OR local_relpath = ?2
> - OR IS_STRICT_DESCENDANT_OF(local_relpath, ?2))
> + AND (parent_relpath = ?2
> + OR IS_STRICT_DESCENDANT_OF(parent_relpath, ?2))
> AND op_depth = 0 AND presence = 'absent'
> LIMIT 1
>
>
>
>
Received on 2012-05-20 02:06:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.