[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1337388 - /subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 14 May 2012 09:49:40 -0400

On 05/11/2012 05:40 PM, gstein_at_apache.org wrote:
> Author: gstein
> Date: Fri May 11 21:40:55 2012
> New Revision: 1337388
>
> URL: http://svn.apache.org/viewvc?rev=1337388&view=rev
> Log:
> Note a problem. The new xml parsers should correct issues like this.
>
> * subversion/libsvn_ra_serf/get_deleted_rev.c:
> (cdata_getdrev): this function could be invoked N times with a
> single character of the revision. the approach used here is wrong.
> leave a marker noting that.

... and these aren't merely theoretical problems -- I've run into several
real-world incidences of this sort before. Need to use a stringbuf to
collect all the CDATA, and transfer to the preferred storage location/format
in the end-tag handler.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-05-14 15:50:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.