[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1337392 - /subversion/trunk/subversion/libsvn_client/commit_util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 12 May 2012 00:12:09 -0400

On Fri, May 11, 2012 at 5:47 PM, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/commit_util.c Fri May 11 21:47:21 2012
>...
> +static svn_error_t *
> +harvest_not_present_for_copy(struct harvest_baton *baton,
> +                             const char *local_abspath,
> +                             const char *repos_root_url,
> +                             const char *commit_relpath,
> +                             apr_pool_t *scratch_pool)

This function doesn't need the whole BATON. There are only five values
needed (and one is RESULT_POOL which is normal dual-pool design rather
than "another argument"). Another is WC_CTX which is also kind of
invisible. So you're really just swapping out BATON for
CHECK_URL_FUNC/BATON and COMMITTABLES.

>...

Cheers,
-g
Received on 2012-05-12 06:12:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.