[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1334512 - /subversion/branches/ev2-export/subversion/libsvn_client/commit_util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 5 May 2012 17:42:17 -0400

On Sat, May 5, 2012 at 5:35 PM, <hwright_at_apache.org> wrote:
>...
> +++ subversion/branches/ev2-export/subversion/libsvn_client/commit_util.c Sat May  5 21:35:28 2012
> @@ -1564,7 +1564,8 @@ do_item_commit(svn_client_commit_item3_t
>   /* If this item is supposed to be deleted, do so. */
>   if (item->state_flags & SVN_CLIENT_COMMIT_ITEM_DELETE)
>     {
> -      err = svn_editor_delete(editor, repos_relpath, item->revision);
> +      err = svn_error_trace(
> +                svn_editor_delete(editor, repos_relpath, item->revision));
>
>       if (err)
>         goto fixup_error;

It seems that you could move the call to fixup_commit_error() into the
one caller of do_item_commit(), and then convert all of these blocks
to a normal SVN_ERR() (which has proper tracing).

The goto's were needed when do_item_commit() was directly called by
the path driver, iirc.

Cheers,
-g
Received on 2012-05-05 23:42:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.