[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1331652 - /subversion/trunk/subversion/libsvn_delta/compat.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 1 May 2012 00:15:54 -0400

On Mon, Apr 30, 2012 at 23:31, Hyrum K Wright <hyrum.wright_at_wandisco.com> wrote:
> On Mon, Apr 30, 2012 at 10:02 PM, Greg Stein <gstein_at_gmail.com> wrote:
>>
>> On Apr 30, 2012 9:38 PM, "Hyrum K Wright" <hyrum.wright_at_wandisco.com> wrote:
>>>...
>>> As the key of the hash, RELPATH should be duplicated into a pool with
>>> sufficient lifetime.
>>
>> Good catch! Fixed in r1332508.
>
> Thanks.  For the same reason, you probably want to
> s/apr_hash_copy/svn_prop_hash_dup/ over compat.c.  The former only
> duplicates the hash, not the keys or the contents, while the latter
> will ensure the prophash has the same lifetime as the change it
> belongs to.

Oop! You're right. Will do after I commit my work-in-progress.

Thx,
-g
Received on 2012-05-01 06:16:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.