[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1326688 - /subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Sat, 28 Apr 2012 14:01:26 +0200

Greg Stein wrote:
>
>
> On Apr 22, 2012 2:09 PM, "Stefan Fuhrmann" <eqfox_at_web.de
> <mailto:eqfox_at_web.de>> wrote:
> >
> > Am 16.04.2012 19:45, schrieb Greg Stein:
> >>...
> >> I also find the need for the has_sufficient_privileges() function
> to be problematic. It seems to indicate you have not encapsulated this
> stuff properly.
> >
> > Indeed, one might see this as an encapsulation issue. With APR.
>
> No doubt. But that doesn't mean you propagate the problem into SVN. I
> would suggest a helper function in libsvn_subr that does this
> platform-specific stuff so that the app (or test, in this case) can
> call that helper. That encapsulates stuff away from the app, even
> though our library may still need to compensate for APR problems.
>

Addressed by r1331760.
Thanks for the review!

-- Stefan^2.
Received on 2012-04-28 16:01:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.